chore: update upgrade scripts #533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…refactoring; fixes
darora
approved these changes
Feb 13, 2023
|
|
||
| echo "Re-enabling extensions" | ||
| if [ -f $POST_UPGRADE_EXTENSION_SCRIPT ]; then | ||
| run_sql -f $POST_UPGRADE_EXTENSION_SCRIPT |
There was a problem hiding this comment.
might be good to run these scripts through shellcheck -- it'd probably get mad about all the non-quoted variables
There was a problem hiding this comment.
Good point! Added a shellcheck workflow to help keep the admin_api_scripts folder in check
|
|
||
| # Make latest libpq available to pg_upgrade | ||
| mkdir -p /usr/lib/postgresql/lib/aarch64 | ||
| if [ ! -L /usr/lib/postgresql/lib/aarch64/libpq.so.5 ]; then |
There was a problem hiding this comment.
hmm do we block upgrades on the older x86 instances at some early stage?
There was a problem hiding this comment.
Not an explicit one - it's tied down to version eligibility since the last version supporting x86 was 12.5.
Will add additional checks in the admin cli and upcoming API support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?