Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for 3.11 #188

Merged
merged 3 commits into from
Jan 24, 2023
Merged

feat: add support for 3.11 #188

merged 3 commits into from
Jan 24, 2023

Conversation

J0
Copy link
Contributor

@J0 J0 commented Jan 23, 2023

see title- makes use of first solution in #169 - we add StrEnum and import StrEnum for older versions

fix: #169

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 23, 2023

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 6.01%.

Quality metrics Before After Change
Complexity 0.00 ⭐ 2.00 ⭐ 2.00 👎
Method Length 129.00 😞 141.00 😞 12.00 👎
Working memory 4.00 ⭐ 5.00 ⭐ 1.00 👎
Quality 79.56% 73.55% 🙂 -6.01% 👎
Other metrics Before After Change
Lines 49 54 5
Changed files Quality Before Quality After Quality Change
postgrest/types.py 79.56% ⭐ 73.55% 🙂 -6.01% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Base: 92.06% // Head: 92.08% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (93d3e30) compared to base (7e87364).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
+ Coverage   92.06%   92.08%   +0.02%     
==========================================
  Files          23       23              
  Lines        1096     1099       +3     
==========================================
+ Hits         1009     1012       +3     
  Misses         87       87              
Impacted Files Coverage Δ
postgrest/types.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@J0 J0 requested a review from anand2312 January 23, 2023 05:08
@J0 J0 merged commit 08f156a into master Jan 24, 2023
@J0 J0 deleted the j0/add-3-11-to-ci branch January 24, 2023 01:52
@guillego
Copy link
Contributor

guillego commented Jan 25, 2023

Hey @J0! I experienced today the issues this PR addresses and was surprised when I saw this had already been merged in the code but it's not available in the releases. It seems like the CI/CD workflow failed due to a version mismatch and the package hasn't been released.

Could you take a look at it? Let me know if there's anything I can help with.

@J0
Copy link
Contributor Author

J0 commented Jan 26, 2023

Hey @guillego,

No worries, will look into it after work today - feel free to bump me if I don't get back to you within 12 hours

@J0
Copy link
Contributor Author

J0 commented Jan 26, 2023

Updated both postgrest and postgrest-py to v0.10.4 on pip3 think anaconda changes might take a while to propagate

Please let me know if there are any issues or if there's anything else y'all need!

@guillego
Copy link
Contributor

Hey @J0, just tested v.0.10.4 and works perfectly! Thanks a lot for getting to it so fast ⚡!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Will mostly fail on Python 3.11 (string enums no longer literal strings)
2 participants