Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: maybe_single return None when no matching result found in database. #289

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

tushar-balwani
Copy link
Contributor

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

Issue - The maybe_single method seems to work when there is a single record in the database matching the query, but if there are no matching results in the database, an error is raised.
supabase/supabase-py#511

Reason - Error message is been updated in postgREST PostgREST/postgrest#2876

What is the new behavior?

New changes return None when no matching result found in database.

@tushar-balwani tushar-balwani force-pushed the bugfix/supabase-py-issue-511 branch from 9f07390 to 9b1c890 Compare August 27, 2023 08:48
Copy link
Contributor

@J0 J0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! We should probably look into more robust way of checking for errors at some point.

@J0 J0 merged commit a5efce6 into supabase:master Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants