Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove pydantic validation for rpc calls #308

Closed
wants to merge 3 commits into from

Conversation

J0
Copy link
Contributor

@J0 J0 commented Sep 17, 2023

What kind of change does this PR introduce?

Currently, there is validation on /rpc calls which don't return responses in the conventional

{
  data: ...
}

format. This causes validation to fail and an error to be throw.

Current fix is hacky - open to suggestions on cleaner ways to fix this

Aims to fix: supabase/supabase-py#405 and #200

Manually tested - briefly converting to draft so I can write a test

@J0 J0 requested a review from olirice as a code owner September 17, 2023 15:09
@codecov
Copy link

codecov bot commented Sep 17, 2023

Codecov Report

Patch coverage: 25.00% and project coverage change: -0.90% ⚠️

Comparison is base (3329234) 91.56% compared to head (3853dc1) 90.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #308      +/-   ##
==========================================
- Coverage   91.56%   90.66%   -0.90%     
==========================================
  Files          24       24              
  Lines        1197     1211      +14     
==========================================
+ Hits         1096     1098       +2     
- Misses        101      113      +12     
Files Changed Coverage Δ
postgrest/_async/request_builder.py 75.45% <25.00%> (-4.16%) ⬇️
postgrest/_sync/request_builder.py 81.81% <25.00%> (-4.59%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@J0 J0 marked this pull request as draft September 17, 2023 15:13
@J0
Copy link
Contributor Author

J0 commented Sep 17, 2023

Let's use #309

@J0 J0 closed this Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rpc() - value is not a valid list
1 participant