Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add csv() modifier #316

Merged
merged 5 commits into from
Oct 6, 2023
Merged

feat: add csv() modifier #316

merged 5 commits into from
Oct 6, 2023

Conversation

anand2312
Copy link
Contributor

@anand2312 anand2312 commented Sep 30, 2023

Notes:

  • Adding a .csv() to the chain will eventually return a SingleAPIResposne[str], whose data field will be the data returned as a CSV string.
  • Calling csv() has a similar effect as calling single() - it has to be the last call in the chain (only .execute() can follow it)

@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5ae0f99) 91.36% compared to head (5906eaf) 91.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #316      +/-   ##
==========================================
+ Coverage   91.36%   91.62%   +0.25%     
==========================================
  Files          24       24              
  Lines        1216     1253      +37     
==========================================
+ Hits         1111     1148      +37     
  Misses        105      105              
Files Coverage Δ
postgrest/__init__.py 100.00% <ø> (ø)
postgrest/_async/request_builder.py 79.27% <100.00%> (+0.57%) ⬆️
postgrest/_sync/request_builder.py 85.58% <100.00%> (+0.40%) ⬆️
postgrest/base_request_builder.py 78.22% <100.00%> (+0.29%) ⬆️
tests/_async/test_request_builder.py 100.00% <100.00%> (ø)
tests/_sync/test_request_builder.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@J0
Copy link
Contributor

J0 commented Oct 6, 2023

Need to add docs as well - I'll look into it when a slot frees up. We should probably record a video on how to update the docs at some point as well

@anand2312 anand2312 merged commit 4f6e9d9 into master Oct 6, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants