Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add python 3.12 to CI #319

Merged
merged 4 commits into from
Oct 11, 2023
Merged

chore: add python 3.12 to CI #319

merged 4 commits into from
Oct 11, 2023

Conversation

anand2312
Copy link
Contributor

@anand2312 anand2312 commented Oct 3, 2023 •
edited
Loading

  • CPython 3.12 was released yesterday - let's add that to our testing matrix.
  • added myself to CODEOWNERS
  • made docs dependencies optional

@anand2312 anand2312 requested review from olirice and J0 as code owners October 3, 2023 02:38
@anand2312
Copy link
Contributor Author

Looks like actions doesn't have it yet 😄 we'll merge when the environment supports it

@codecov
Copy link

codecov bot commented Oct 11, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5ae0f99) 91.36% compared to head (8c20e5b) 92.13%.
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
+ Coverage   91.36%   92.13%   +0.77%     
==========================================
  Files          24       24              
  Lines        1216     1501     +285     
==========================================
+ Hits         1111     1383     +272     
- Misses        105      118      +13

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

J0
J0 approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@J0 J0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@anand2312 anand2312 merged commit d1ee0bb into master Oct 11, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J0 J0 J0 approved these changes

@olirice olirice Awaiting requested review from olirice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anand2312 @J0