-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add get, head and count parameters to the rpc method. #444
Merged
+36
−6
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
from __future__ import annotations | ||
|
||
from typing import Any, Dict, Union, cast | ||
from typing import Any, Dict, Optional, Union, cast | ||
|
||
from deprecation import deprecated | ||
from httpx import Headers, QueryParams, Timeout | ||
|
@@ -11,6 +11,7 @@ | |
DEFAULT_POSTGREST_CLIENT_HEADERS, | ||
DEFAULT_POSTGREST_CLIENT_TIMEOUT, | ||
) | ||
from ..types import CountMethod | ||
from ..utils import SyncClient | ||
from .request_builder import SyncRequestBuilder, SyncRPCFilterRequestBuilder | ||
|
||
|
@@ -78,12 +79,22 @@ def from_table(self, table: str) -> SyncRequestBuilder: | |
"""Alias to :meth:`from_`.""" | ||
return self.from_(table) | ||
|
||
def rpc(self, func: str, params: dict) -> SyncRPCFilterRequestBuilder[Any]: | ||
def rpc( | ||
self, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. issue (code-quality): We've found these issues:
|
||
func: str, | ||
params: dict, | ||
count: Optional[CountMethod] = None, | ||
head: bool = False, | ||
get: bool = False, | ||
) -> SyncRPCFilterRequestBuilder[Any]: | ||
"""Perform a stored procedure call. | ||
Args: | ||
func: The name of the remote procedure to run. | ||
params: The parameters to be passed to the remote procedure. | ||
count: The method to use to get the count of rows returned. | ||
head: When set to `true`, `data` will not be returned. Useful if you only need the count. | ||
get: When set to `true`, the function will be called with read-only access mode. | ||
Returns: | ||
:class:`AsyncRPCFilterRequestBuilder` | ||
Example: | ||
|
@@ -97,7 +108,11 @@ def rpc(self, func: str, params: dict) -> SyncRPCFilterRequestBuilder[Any]: | |
This method now returns a :class:`AsyncFilterRequestBuilder` which allows you to | ||
filter on the RPC's resultset. | ||
""" | ||
method = "HEAD" if head else "GET" if get else "POST" | ||
|
||
headers = Headers({"Prefer": f"count={count}"}) if count else Headers() | ||
|
||
# the params here are params to be sent to the RPC and not the queryparams! | ||
return SyncRPCFilterRequestBuilder[Any]( | ||
self.session, f"/rpc/{func}", "POST", Headers(), QueryParams(), json=params | ||
self.session, f"/rpc/{func}", method, headers, QueryParams(), json=params | ||
) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (code-quality): We've found these issues:
else
branch (introduce-default-else
)split-or-ifs
)merge-duplicate-blocks
)remove-redundant-if
)