Convert SECURE_CHANNELS value from boolean to string #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w3b6x9
commented
Jan 24, 2021
| @@ -13,7 +13,8 @@ ENV MIX_ENV=prod \ | |||
| MIX_ENV=prod \ | |||
| PORT=4000 \ | |||
| HOSTNAME=localhost \ | |||
| JWT_SECRET=SOMETHING_SUPER_SECRET | |||
| JWT_SECRET=SOMETHING_SUPER_SECRET \ | |||
| SECURE_CHANNELS=true | |||
There was a problem hiding this comment.
@soedirgo since this is a Dockerfile, doesn't matter if it's true or 'true'.
|
🎉 This PR is included in version 0.10.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
kiwicopple
pushed a commit
to kiwicopple/realtime
that referenced
this pull request
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Docs update
What is the current behavior?
What is the new behavior?
SECURE_CHANNELSandJWT_CLAIM_VALIDATORSare labeled asstringvalues.Additional context
I think this is the better call considering they technically are strings coming in, and the application picks it up and converts them to boolean and JSON object.
Related issue: #107