fix: StorageError shape to match returned errors from API #214
+5
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
#165
What is the current behavior?
The StorageApiError class defined in storage-js has a status field.
The StorageError defined in storage-api has a statusCode field.
This mismatch make it difficult to correctly handle errors on the frontend.
I'd like to use the isStorageError function defined in storage-js, but it does not recognize errors thrown from the API
What is the new behavior?
Update
StorageApiError
class and error handling to match API returned errorsStorageApiError
class insrc/lib/errors.ts
to have astatusCode
field instead ofstatus
toJSON
method inStorageApiError
class to returnstatusCode
instead ofstatus
handleError
function insrc/lib/fetch.ts
to handlestatusCode
instead ofstatus
Additional context
Supabase Storage API scheme
https://supabase.github.io/storage/