Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting !!! TypeError: __init__() got an unexpected keyword argument 'file_size_limit' #71

Closed
starascendin opened this issue Feb 27, 2023 · 9 comments

Comments

@starascendin
Copy link

starascendin commented Feb 27, 2023

Describe the bug
Using supabase 1.0.1 and storage3 0.5.0, i'm getting error !!! TypeError: __init__() got an unexpected keyword argument 'file_size_limit'

        res = self._request("GET", f"/bucket/{id}")
        json = res.json()
        return SyncBucket(**json, _client=self._client)

@conanmalanaphy
Copy link

conanmalanaphy commented Feb 27, 2023

I'm also getting this error. Could it be to do with the update to postgrest-py that happened in the last 18 hours?

@GaryAustin1
Copy link

GaryAustin1 commented Feb 27, 2023

This is likely do to a change in the storage.buckets table adding new columns for coming features(?)....
image

This changes was rolled out a few days ago here: supabase/storage#277

And likely just hit instances in the past day.

@conanmalanaphy
Copy link

Thanks for that - it's answered the question :D but is there anything I can do to fix this or do we need to wait for a dev?

@GaryAustin1
Copy link

GaryAustin1 commented Feb 27, 2023

Seems like python cares about the structure of the buckets table for some reason, but as I mentioned in Discord I don't know anything about python. Is there away to turn off the "type checking" that is going on? Otherwise, if you could figure out in this python code what needs to be added to deal with the new columns and generate your own temp version that would be one way.

I don't think it is wise, or possibly even possible, to delete those columns from storage.buckets until it gets fixed here as that might break the storage-api code.

@conanmalanaphy
Copy link

How long does it normally take to fix issues. I can assume this one isn't too difficult.

@G-structure
Copy link
Contributor

@starascendin
@conanmalanaphy

This PR fixes the issue for me.

Uninstall storage3 and install it with pip

pip uninstall storage3
pip install git+https://github.com/supabase-community/storage-py.git@refs/pull/72/merge

@starascendin
Copy link
Author

starascendin commented Feb 27, 2023

@starascendin @conanmalanaphy

This PR fixes the issue for me.

Uninstall storage3 and install it with pip

pip uninstall storage3
pip install git+https://github.com/supabase-community/storage-py.git@refs/pull/72/merge

confirm this fixes the issue.

Hope the devs can merge in this fix and update the package. Thanks @ChartierLuc for putting this up 🔥

@J0
Copy link
Collaborator

J0 commented Mar 4, 2023

Hey team,

Thanks for the quick PR! One of the Python Maintainers here - we'll review by end of day and have a release out by the end of the weekend :)

@J0
Copy link
Collaborator

J0 commented Mar 5, 2023

published new release, feel free to ping me again if there are issues.

Once again, thanks @ChartierLuc for the PR!

@J0 J0 closed this as completed Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants