Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to customise max file size and mime types at bucket level #277

Merged
merged 5 commits into from
Feb 21, 2023

Conversation

fenos
Copy link
Contributor

@fenos fenos commented Feb 8, 2023

What kind of change does this PR introduce?

Feature

What is the new behavior?

  • Allow creating buckets specifying a file size limit and white-listing mime-types which will serve for validating the file during upload

  • Allow to update these values via the bucket update endpoint

  • Validate max file size and mime type during upload

@coveralls
Copy link

coveralls commented Feb 8, 2023

Pull Request Test Coverage Report for Build 4125039381

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 155 of 171 (90.64%) changed or added relevant lines in 13 files are covered.
  • 120 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.1%) to 85.663%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/storage/backend/s3.ts 13 14 92.86%
src/app.ts 4 6 66.67%
src/monitoring/logger.ts 0 2 0.0%
src/storage/storage.ts 37 42 88.1%
src/storage/renderer/image.ts 13 19 68.42%
Files with Coverage Reduction New Missed Lines %
src/monitoring/logger.ts 1 41.74%
src/config.ts 2 94.08%
src/app.ts 4 74.24%
src/storage/storage.ts 22 82.22%
src/storage/renderer/image.ts 38 75.37%
src/storage/backend/s3.ts 53 42.32%
Totals Coverage Status
Change from base Build 4023213000: -0.1%
Covered Lines: 5004
Relevant Lines: 5809

💛 - Coveralls

src/http/routes/bucket/updateBucket.ts Outdated Show resolved Hide resolved
@fenos fenos merged commit eced90e into master Feb 21, 2023
@fenos fenos deleted the feat/customise-bucker-level-size-mime-types branch February 21, 2023 10:27
@github-actions
Copy link

🎉 This PR is included in version 0.29.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants