-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: created functions to get multiple signed URLs. #105
feat: created functions to get multiple signed URLs. #105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@dishwad run Also you don't have to manually write the code for the sync client, we generate that using unasync - |
Ok I removed the code for the sync client and the sync test. I ran |
Hm might be the case that |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
==========================================
- Coverage 87.18% 85.71% -1.48%
==========================================
Files 12 12
Lines 320 371 +51
==========================================
+ Hits 279 318 +39
- Misses 41 53 +12
☔ View full report in Codecov by Sentry. |
Odd - the pre-commit hook for black was reformatting |
Addresses issues:
#104