BUGFIX: NoneType object has no attribute lstrip
#126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking if "signedURL" exists before trying to strip "/". `cast` doesn't convert `NoneType` to `str` at runtime if there is no signedURL returned.
SiddhantSadangi
changed the title
NoneType object has no attribute lstrip
|
This pull request is stale because it has been open for 365 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking if "signedURL" exists before trying to strip "/".
castdoesn't convertNoneTypetostrat runtime if there is no signedURL returned.What kind of change does this PR introduce?
Bug fix
What is the current behavior?
If
get_signed_urlorget_signed_urlsdon't return a signedURL for a file,cast(str, item['signedURL']).lstrip('/')fails with error 'NoneType' object has no attribute 'lstrip'.What is the new behavior?
item['signedURL'].lstrip('/')will run only ifitem['signedURL']exists.Also removed
castfrom import as it was only being used here.Additional context
Add any other context or screenshots.