Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add update existing file function #165

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Conversation

silentworks
Copy link
Collaborator

@silentworks silentworks commented Nov 22, 2023

What kind of change does this PR introduce?

Add missing update feature

What is the current behavior?

No update feature for files

What is the new behavior?

Update feature for files

Additional context

Need to update the docs site to include an example

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (fc8cb5d) 84.09% compared to head (18c14a4) 84.36%.

Files Patch % Lines
storage3/_async/file_api.py 77.77% 2 Missing ⚠️
storage3/_sync/file_api.py 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
+ Coverage   84.09%   84.36%   +0.27%     
==========================================
  Files          12       12              
  Lines         459      467       +8     
==========================================
+ Hits          386      394       +8     
  Misses         73       73              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@silentworks silentworks merged commit d8139e0 into main Nov 22, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants