fix: handle json decode error when there's no json response (e.g. on 403) #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J0
changed the title
J0
changed the title
J0
commented
Mar 10, 2024
| resp = response.json() | ||
| raise StorageException({**resp, "statusCode": response.status_code}) | ||
| except JSONDecodeError: | ||
| raise StorageException({"statusCode": response.status_code}) |
There was a problem hiding this comment.
Considered adding
"error": "unknown error occurred"
but didn't want to put in a field here just yet. Prefer to revisit on Mon but also open to suggestions if anyone has ideas on how best to return this error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Seeks to fix supabase/supabase-py#721
We should probably add better error handling at some point - went with a minimal fix for now