Skip to content
This repository was archived by the owner on Sep 8, 2025. It is now read-only.

Conversation

@silentworks
Copy link
Collaborator

@silentworks silentworks commented Dec 25, 2024

What kind of change does this PR introduce?

  • Add custom metadata on upload
  • Fix warnings tests were giving with pytest-asyncio

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

Custom Metadata

Adds support for custom metadata on objects:

storage.from_(bucketName).upload(uploadPath, file, {
        "metadata": {
          "custom": "metadata",
          "second": "second",
          "third": "third",
        },
})

Additional context

Relates to supabase/storage#439
#295
supabase/storage-js#207

@silentworks silentworks requested review from J0 and grdsdev December 25, 2024 16:41
@silentworks silentworks linked an issue Dec 25, 2024 that may be closed by this pull request
Copy link
Contributor

@J0 J0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@silentworks silentworks merged commit d4f9794 into main Dec 30, 2024
12 checks passed
@silentworks silentworks deleted the silentworks/custom-metadata branch December 30, 2024 11:57
@dillahCodes
Copy link

hi @silentworks how to get metadata from the file?

@lauri865
Copy link

I guess TUS doesn't support x-medata header yet @silentworks? Would be a great addition.

@lauri865
Copy link

Ah, it's possible to provide it as part of metadata.metadata in the TUS client rather than headers.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for custom metadata, new info and exists method

4 participants