refactor(gotrue): Remove unused _currentUser field and update currentUser getter logic. #1168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…User getter logic. Simplified comments and fixed some nullcheck operators
juampiq6
commented
May 7, 2025
| @@ -997,7 +992,7 @@ class GoTrueClient { | |||
| } | |||
| } else { | |||
| final shouldEmitEvent = _currentSession == null || | |||
There was a problem hiding this comment.
if current session is null, then the second bang operator in the expression will never reach
juampiq6
commented
May 7, 2025
| @@ -748,8 +745,7 @@ class GoTrueClient { | |||
| options: options); | |||
| final userResponse = UserResponse.fromJson(response); | |||
|
|
|||
| _currentUser = userResponse.user; | |||
| _currentSession = currentSession?.copyWith(user: userResponse.user); | |||
| _currentSession = currentSession!.copyWith(user: userResponse.user); | |||
There was a problem hiding this comment.
if access token is null, then the code will never reach the bang operator, hence it should be safe to use it here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactor
What is the current behavior?
_currentUser variable is just being stored as a copy of _currentSession.user
What is the new behavior?
The currentUser getter is handling the indirection correctly, no need to duplicate values and assign both each time they change.
Additional context
I have simplified a comment (it was a double negation).
I have added some bang operators in cases where null-aware operator where not needed