fix(realtime): realtime explicit REST call #1749
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grdsdev
approved these changes
Oct 8, 2025
grdsdev
added a commit
to supabase/supabase-swift
that referenced
this pull request
Oct 8, 2025
This commit ports the feature from supabase-js PR #1749 which adds an explicit `postSend()` method for sending broadcast messages via REST API, addressing the issue where users may unknowingly use REST fallback when WebSocket is not connected. Changes: - Add `postSend()` method to RealtimeChannelV2 for explicit REST delivery - Add deprecation warning to `broadcast()` when falling back to REST - Add comprehensive test coverage for the new method - Support custom timeout parameter for REST requests - Include proper error handling and status code validation The `postSend()` method always uses the REST API endpoint regardless of WebSocket connection state, making it clear to developers when they are using REST vs WebSocket delivery. Ref: supabase/supabase-js#1749 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
5 tasks
edgurgel
reviewed
Oct 8, 2025
| opts: { timeout?: number } = {} | ||
| ): Promise<{ success: true } | { success: false; status: number; error: string }> { | ||
| if (!this.socket.accessTokenValue) { | ||
| return Promise.reject('Access token is required for postSend()') |
There was a problem hiding this comment.
What if the secret key is being used? Would we still need an access token?
|
#1751 as we need this to be a minor version change |
grdsdev
added a commit
to supabase/supabase-swift
that referenced
this pull request
Oct 10, 2025
* fix(realtime): add explicit REST API broadcast method This commit ports the feature from supabase-js PR #1749 which adds an explicit `postSend()` method for sending broadcast messages via REST API, addressing the issue where users may unknowingly use REST fallback when WebSocket is not connected. Changes: - Add `postSend()` method to RealtimeChannelV2 for explicit REST delivery - Add deprecation warning to `broadcast()` when falling back to REST - Add comprehensive test coverage for the new method - Support custom timeout parameter for REST requests - Include proper error handling and status code validation The `postSend()` method always uses the REST API endpoint regardless of WebSocket connection state, making it clear to developers when they are using REST vs WebSocket delivery. Ref: supabase/supabase-js#1749 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * refactor: rename postSend to httpSend Rename the explicit REST API broadcast method from postSend to httpSend to better align with naming conventions. Changes: - Rename postSend() to httpSend() in RealtimeChannelV2 - Update all test names from testPostSend to testHttpSend - Update deprecation warning to reference httpSend() - Update error messages to reference httpSend() All tests continue to pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * drop MainActor * simplify try/catch * reuse BroadcastMessagePayload --------- Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Description
Added new public method for explicit usage of REST API for broadcast
What changed?
New method
httpSendaddedWhy was this change needed?
Our current approach leads users to use broadcast without knowing.
🔄 Breaking changes
sendwhile not connected.📋 Checklist
<type>(<scope>): <description>npx nx formatto ensure consistent code formatting