fix: race condition when accessing SupabaseClient #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshukertjr
approved these changes
May 15, 2024
|
@grdsdev you're awesome. Thanks for coming up with this fix so quickly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
I wasn't able to reproduce it, but I have an assumption that these changes may fix the following crashes.
Fix #239
Fix #385
What is the current behavior?
Inner clients from SupabaseClient were defined as
lazy var, butlazy varisn't thread-safe in Swift, this was probably causing some crashes when accessed from different threads.We also relied on it to mark the
SupabaseClientclass as@unchecked Sendable.What is the new behavior?
Moved inner clients to a
LockIsolatedand madeSupabaseClientconform toSendable.