docs: clarify language in range documentation #30989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change parameter names from start/end to from/to for consistency - Fix incorrect offset description in notes section
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Skipped Deployments
|
|
@RaghavgitGrover is attempting to deploy a commit to the Supabase Team on Vercel. A member of the Team first needs to authorize it. |
charislam
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Thanks @RaghavgitGrover! Good catches!
Just a minor edit: Since the parameters are named start and end (see source), I've opted to keep those names, but made everything consistent by renaming from and to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #908 in supabase/supabase-py repo
I have read the CONTRIBUTING.md file.
YES
What kind of change does this PR introduce?
docs update
What is the current behavior?
The python range documentation has the following issues:
startandendwhile the description usesfromandtofrom) and ending at the offset (from + to)". This is incorrect as the end index is justto. E.g.range(20, 30)returns 11 items (20-30), not 51 items (20-20+30)What is the new behavior?
fromandtoin parameter list. This is aligned with the documentation for other languages.toAdditional context
Add any other context or screenshots.
