Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add more Stripe test cases #30

Merged
merged 6 commits into from
Dec 8, 2022
Merged

Conversation

burmecia
Copy link
Member

@burmecia burmecia commented Dec 8, 2022

What kind of change does this PR introduce?

This PR is to add more smoke test cases for Stripe FDW.

What is the current behavior?

Currently, there are only 3 test cases:

  1. Balance
  2. Customers
  3. Subscriptions

What is the new behavior?

More test cases will be added:

  1. Balance
  2. Balance Transactions
  3. Charges
  4. Customers
  5. Invoices
  6. PaymentIntents
  7. Products
  8. Subscriptions

Additional context

N/A

@burmecia burmecia requested a review from olirice December 8, 2022 06:40
Copy link
Collaborator

@olirice olirice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

for the tables that support insert, update, and where clause push down could that included too?

@burmecia
Copy link
Member Author

burmecia commented Dec 8, 2022

looks great!

for the tables that support insert, update, and where clause push down could that included too?

Code added, but the Stripe mock container doesn't support data modify, so I commented it out.

https://github.com/stripe/stripe-mock#current-state-of-development

@olirice olirice self-requested a review December 8, 2022 17:03
@olirice olirice merged commit b1f10e6 into main Dec 8, 2022
@olirice olirice deleted the chore/add_stripe_test_cases branch December 8, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants