Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change all wasm fdw host version requirement #303

Merged
merged 2 commits into from
Aug 9, 2024
+7 −4
Merged

chore: change all wasm fdw host version requirement #303

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efb1446
chore: change all wasm fdw version requirements
burmecia Jul 8, 2024
3b5e7e6
merge from main
burmecia Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion wasm-wrappers/fdw/helloworld_fdw/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ impl HelloWorldFdw {

impl Guest for HelloWorldFdw {
fn host_version_requirement() -> String {
">=0.1.0".to_string()
// semver ref: https://docs.rs/semver/latest/semver/enum.Op.html
"^0.1.0".to_string()
}

fn init(_ctx: &Context) -> FdwResult {
Expand Down
2 changes: 1 addition & 1 deletion wasm-wrappers/fdw/paddle_fdw/src/bindings.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4434,7 +4434,7 @@ pub mod exports {
/// ----------------------------------------------
/// foreign data wrapper interface functions
/// ----------------------------------------------
/// define minimal host version requirement, e.g, ">=1.2.3"
/// define host version requirement, e.g, "^1.2.3"
fn host_version_requirement() -> _rt::String;
/// fdw initialization
fn init(ctx: &Context) -> FdwResult;
Expand Down
3 changes: 2 additions & 1 deletion wasm-wrappers/fdw/paddle_fdw/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,8 @@ impl PaddleFdw {

impl Guest for PaddleFdw {
fn host_version_requirement() -> String {
">=0.1.0".to_string()
// semver ref: https://docs.rs/semver/latest/semver/enum.Op.html
"^0.1.0".to_string()
}

fn init(ctx: &Context) -> FdwResult {
Expand Down
3 changes: 2 additions & 1 deletion wasm-wrappers/fdw/snowflake_fdw/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,8 @@ impl SnowflakeFdw {

impl Guest for SnowflakeFdw {
fn host_version_requirement() -> String {
">=0.1.0".to_string()
// semver ref: https://docs.rs/semver/latest/semver/enum.Op.html
"^0.1.0".to_string()
}

fn init(ctx: &Context) -> FdwResult {
Expand Down
2 changes: 1 addition & 1 deletion wasm-wrappers/wit/routines.wit
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ interface routines {
// foreign data wrapper interface functions
// ----------------------------------------------

// define minimal host version requirement, e.g, ">=1.2.3"
// define host version requirement, e.g, "^1.2.3"
host-version-requirement: func() -> string;

// fdw initialization
Expand Down
Loading