Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add boolean test qual support #341

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

burmecia
Copy link
Member

@burmecia burmecia commented Sep 9, 2024

What kind of change does this PR introduce?

This PR is to add boolean test qual support to Wrappers. Fix #340 .

What is the current behavior?

Currently, the boolean test quals, like bool_col is true or bool_col is not false, are not supported by Wrappers.

What is the new behavior?

Added support for boolean test quals. The qual is_admin is active is parsed like Qual { field: "is_admin", operator: "is", value: Cell(Bool(true)), use_or: false, param: None }.

Additional context

Mssql FDW is changed to adopt this new feature.

@burmecia burmecia added the enhancement New feature or request label Sep 9, 2024
@burmecia burmecia requested a review from imor September 9, 2024 05:59
@burmecia burmecia merged commit 967ea97 into main Sep 19, 2024
3 checks passed
@burmecia burmecia deleted the bo/feat/bool-test-qual branch September 19, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning with MSSQL "bit" types
2 participants