Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add special treatment for null check in qual #59

Merged
merged 2 commits into from
Feb 18, 2023

Conversation

burmecia
Copy link
Member

What kind of change does this PR introduce?

This PR is to fix a bug in qual.deparse() when dealing with null check condition.

What is the current behavior?

#58

What is the new behavior?

The null check in qual should be deparsed correctly.

Additional context

N/A

@burmecia burmecia self-assigned this Feb 17, 2023
@burmecia burmecia requested a review from olirice February 17, 2023 07:46
@burmecia burmecia added the bug Something isn't working label Feb 17, 2023
@burmecia burmecia requested a review from yrashk February 17, 2023 07:50
Copy link
Collaborator

@olirice olirice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@burmecia approved! would be great to add a test for this too so it can't regress

@burmecia burmecia merged commit 0ef910a into main Feb 18, 2023
@burmecia burmecia deleted the fix/qual-deparse-null branch February 18, 2023 01:20
kamyshdm pushed a commit to dymium-io/supabase-wrappers that referenced this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants