Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exclude generated column #72

Merged
merged 4 commits into from
Mar 15, 2023
Merged

Conversation

burmecia
Copy link
Member

@burmecia burmecia commented Mar 14, 2023

What kind of change does this PR introduce?

This PR is to exclude generated column from target columns, so to fix #71 .

What is the current behavior?

The generated column is not supported yet, but it currently reports an error when using it.

What is the new behavior?

Although generated column is not supported, it should report a warning instead an error.

Additional context

N/A

@burmecia burmecia self-assigned this Mar 14, 2023
@burmecia burmecia added the bug Something isn't working label Mar 14, 2023
@burmecia burmecia marked this pull request as ready for review March 14, 2023 14:55
@burmecia burmecia requested a review from olirice March 14, 2023 14:56
@burmecia burmecia merged commit 7604580 into main Mar 15, 2023
@burmecia burmecia deleted the fix/disable-generated-column branch March 15, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigQuery wrapper: generated column error
2 participants