Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add numeric type support and timeout option for bq fdw #78

Merged
merged 3 commits into from
Apr 4, 2023
Merged

feat: add numeric type support and timeout option for bq fdw #78

merged 3 commits into from
Apr 4, 2023

Conversation

burmecia
Copy link
Member

@burmecia burmecia commented Apr 3, 2023 •
edited
Loading

What kind of change does this PR introduce?

This PR added below 2 features to BigQuery FDW:

  1. NUMERIC data type support
  2. timeout foreign table option

What is the current behavior?

  1. There is no support for NUMERIC data type. See details: BigQuery wrapper: JSON, Numeric not supported #70 (comment)
  2. Current query request timeout is 10 seconds, it will return empty result if it expired.

What is the new behavior?

  1. NUMERIC data type is supported
  2. Default query request timeout is 30 seconds and can be adjusted by foreign table option timeout, will also raise error if timeout expired.

Additional context

N/A

@burmecia burmecia requested a review from olirice April 3, 2023 10:16
@burmecia burmecia merged commit 0cd81d1 into main Apr 4, 2023
@burmecia burmecia deleted the feat/add-numeric-bq-fdw branch April 4, 2023 00:48
@rubenvereecken rubenvereecken mentioned this pull request Jul 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olirice olirice olirice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@burmecia @olirice