Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Simple ncurses window with ls-like output #11
base: master
Are you sure you want to change the base?
UI: Simple ncurses window with ls-like output #11
Changes from all commits
0c5bfaf
feab7cd
27167fc
b4a7b03
13fbf3e
821a8bd
d91556c
ce45cba
524826a
2cde7b1
ab403cb
3a243de
629d678
01fcb87
c93400d
3042533
20b23df
69b5ef7
e5f148c
8c23f55
8afbfc9
3094bdf
a8ffa77
e612460
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This class does not contain any logic, therefore it remains abstract, so we couldn't use it as "dummy" class.
Seems it needs to implement the stub
update()
method.This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we should make a CMake module which will export the Curses imported target and use it (like
target_link_libraries(rang PUBLIC Curses::Curses)
. This approach is more clear and we could avoid the cumbersome adding of include_directories and libraries if we declare it as INTERFACE in our imported target:target_include_directories(Curses::Curses INTERFACE ${CURSES_INCLUDE_DIRS})
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also prefer the FindBoost's exported targets here: Boost::system Boost::thread.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to add comment why this
#undef
directive is here or drop it, if it doesn't use.