Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a more explicit note on SSR #322

Merged
merged 1 commit into from
Jun 26, 2019
Merged

Conversation

ValentinH
Copy link
Contributor

There is already a How to implement server-side rendering link to a very nice article. However, we should still be explicit regarding not to use ConnectedRouter on server-side.

Indeed, in one of our applications, we happen to be running with the ConnectedRouter on server-side and it was running fine. However, after updating react-redux to 7.1 (from 7.0), the app was starting to break. This was due to the fact that we were using the context prop like the staticContext prop of StaticRouter 😬 Of course, all our logic using the StaticContext was also silently breaking ^^

There is already a `How to implement server-side rendering` link to a very nice article. However, we should still be explicit regarding not to use `ConnectedRouter` on server-side.

Indeed, in one of our applications, we happen to be running with  the `ConnectedRouter` on server-side and it was running fine. However, after updating `react-redux` to `7.1` (from `7.0`), the app was starting to break. This was due to the fact that we were using the `context` prop like the `staticContext` prop of `StaticRouter` 😬 Of course, all our logic using the `StaticContext` was also silently breaking ^^
@supasate
Copy link
Owner

Thanks for catching this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants