Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NHUB-534] Implement section filters async #1077

Merged
merged 19 commits into from
Sep 13, 2024
Merged

[NHUB-534] Implement section filters async #1077

merged 19 commits into from
Sep 13, 2024

Conversation

eos87
Copy link
Contributor

@eos87 eos87 commented Sep 6, 2024 •
edited by jira bot
Loading

Purpose

Implement the section filters management with new Async framework

What has changed

  • Added new model for section filters, service class and corresponding module
  • Updated views to use new endpoints group + reference to new service class

This PR depends on superdesk/superdesk-core#2688

Resolves: NHUB-534

eos87 added 5 commits September 5, 2024 19:27
@eos87
Implement async service, module and update views
a698cf6 
NHUB-534
@eos87
Fix section filters tests
29e4c9c 
NHUB-534
@eos87
Set old section_filters app back
b9240ab 
The complexity of moving all the references to the new async service is too high to address in ticket NHUB-534.

NHUB-534
@eos87
Implement section filter methods in async service
c5c760e 
NHUB-534
@eos87
Move news_api section filters
37a9a27 
NHUB-534
devketanpro
devketanpro approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@devketanpro devketanpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

eos87
eos87 commented Sep 9, 2024
View reviewed changes
dev-requirements.txt Outdated Show resolved Hide resolved
MarkLark86
MarkLark86 reviewed Sep 10, 2024
View reviewed changes
newsroom/section_filters/model.py Outdated Show resolved Hide resolved
newsroom/section_filters/service.py Outdated Show resolved Hide resolved
newsroom/section_filters/service.py Outdated Show resolved Hide resolved
newsroom/section_filters/service.py Outdated Show resolved Hide resolved
newsroom/section_filters/views.py Outdated Show resolved Hide resolved
newsroom/section_filters/views.py Show resolved Hide resolved
newsroom/section_filters/views.py Outdated Show resolved Hide resolved
newsroom/utils.py Show resolved Hide resolved
newsroom/utils.py Show resolved Hide resolved
@eos87 eos87 requested a review from MarkLark86 September 10, 2024 14:37
@eos87 eos87 merged commit e2f6a38 into async Sep 13, 2024
12 checks passed
@eos87 eos87 deleted the hg/NHUB-534-section-filters-async branch September 13, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devketanpro devketanpro devketanpro approved these changes

@MarkLark86 MarkLark86 MarkLark86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eos87 @MarkLark86 @devketanpro