Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid race condition on push #1084

Merged
merged 1 commit into from
Sep 16, 2024
Merged

avoid race condition on push #1084

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 34 additions & 28 deletions newsroom/push.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,35 +88,41 @@ def push():
assert "guid" in item or "_id" in item, {"guid": 1}
assert "type" in item, {"type": 1}

signals.push.send(app._get_current_object(), item=item)

if item.get("type") == "event":
orig = app.data.find_one("agenda", req=None, _id=item["guid"])
_id = publish_event(item, orig)
notify_new_agenda_item.delay(_id, check_topics=True, is_new=orig is None)
elif item.get("type") == "planning":
orig = app.data.find_one("agenda", req=None, _id=item["guid"]) or {}
item["planning_date"] = parse_date_str(item["planning_date"])
plan_id = publish_planning_item(item, orig)
event_id = publish_planning_into_event(item)
# Prefer parent Event when sending notificaitons
_id = event_id or plan_id
notify_new_agenda_item.delay(_id, check_topics=True, is_new=orig is None)
elif item.get("type") == "text":
orig = superdesk.get_resource_service("items").find_one(req=None, _id=item["guid"])
item["_id"] = publish_item(item, orig)
if not item.get("nextversion"):
notify_new_wire_item.delay(
item["_id"], check_topics=orig is None or app.config["WIRE_NOTIFICATIONS_ON_CORRECTIONS"]
)
elif item["type"] == "planning_featured":
publish_planning_featured(item)
else:
flask.abort(400, gettext("Unknown type {}".format(item.get("type"))))
lock_name = f"push-{item.get('guid') or item.get('_id')}"
if not lock(lock_name, expire=60):
return flask.abort(503)
try:
signals.push.send(app._get_current_object(), item=item)

if item.get("type") == "event":
orig = app.data.find_one("agenda", req=None, _id=item["guid"])
_id = publish_event(item, orig)
notify_new_agenda_item.delay(_id, check_topics=True, is_new=orig is None)
elif item.get("type") == "planning":
orig = app.data.find_one("agenda", req=None, _id=item["guid"]) or {}
item["planning_date"] = parse_date_str(item["planning_date"])
plan_id = publish_planning_item(item, orig)
event_id = publish_planning_into_event(item)
# Prefer parent Event when sending notificaitons
_id = event_id or plan_id
notify_new_agenda_item.delay(_id, check_topics=True, is_new=orig is None)
elif item.get("type") == "text":
orig = superdesk.get_resource_service("items").find_one(req=None, _id=item["guid"])
item["_id"] = publish_item(item, orig)
if not item.get("nextversion"):
notify_new_wire_item.delay(
item["_id"], check_topics=orig is None or app.config["WIRE_NOTIFICATIONS_ON_CORRECTIONS"]
)
elif item["type"] == "planning_featured":
publish_planning_featured(item)
else:
flask.abort(400, gettext("Unknown type {}".format(item.get("type"))))

if app.config.get("DELETE_DASHBOARD_CACHE_ON_PUSH", True):
delete_dashboard_caches()
return flask.jsonify({})
if app.config.get("DELETE_DASHBOARD_CACHE_ON_PUSH", True):
delete_dashboard_caches()
return flask.jsonify({})
finally:
unlock(lock_name)


def set_dates(doc):
Expand Down
Loading