Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STTNHUB-379] fix: Planning items not shown in event preview with AGENDA_DEFAULT_FILTER_HIDE_PLANNING config #1173

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

MarkLark86
Copy link
Contributor

@MarkLark86 MarkLark86 commented Nov 26, 2024

Purpose

When AGENDA_DEFAULT_FILTER_HIDE_PLANNING config is enabled, no Planning item's are being displayed in the preview of an Event when in the "Events & Coverages" filter.

What has changed

  • Make sure the back-end includes the planning_items attribute on the Event
  • Expose the AGENDA_DEFAULT_FILTER_HIDE_PLANNING back-end config to the front-end
  • If item type filter is Events & Coverages and AGENDA_DEFAULT_FILTER_HIDE_PLANNING config is on, then don't include extra dates from planning items for showing in the list (only show the top level Event).

Checklist

  • This pull request is not adding new forms that use redux
  • This pull request is adding missing TypeScript types to modified code segments where it's easy to do so with confidence
  • This pull request is replacing lodash.get with optional chaining for modified code segments

Resolves: STTNHUB-379

@MarkLark86 MarkLark86 added this to the v2.8.1 milestone Nov 26, 2024
@MarkLark86 MarkLark86 requested a review from petrjasek November 26, 2024 02:55
@MarkLark86 MarkLark86 merged commit 8aa1c68 into superdesk:release/2.8 Nov 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants