Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix errors from logs #1195

Merged
merged 1 commit into from
Dec 10, 2024
Merged

fix errors from logs #1195

merged 1 commit into from
Dec 10, 2024

Conversation

petrjasek
Copy link
Member

Dec  6 15:58:43 nh-cpcn-uat sh[1477]: 15:58:43 web.1         | --- Logging error ---
Dec  6 15:58:43 nh-cpcn-uat sh[1477]: 15:58:43 web.1         | Traceback (most recent call last):
Dec  6 15:58:43 nh-cpcn-uat sh[1477]: 15:58:43 web.1         |   File "/opt/newsroom/server/env/lib/python3.10/site-packages/newsroom/wire/search.py", line 148, in get_items
Dec  6 15:58:43 nh-cpcn-uat sh[1477]: 15:58:43 web.1         |     self.apply_filters(search)
Dec  6 15:58:43 nh-cpcn-uat sh[1477]: 15:58:43 web.1         |   File "/opt/newsroom/server/env/lib/python3.10/site-packages/newsroom/search/service.py", line 303, in apply_filters
Dec  6 15:58:43 nh-cpcn-uat sh[1477]: 15:58:43 web.1         |     self.apply_request_filter(search)
Dec  6 15:58:43 nh-cpcn-uat sh[1477]: 15:58:43 web.1         |   File "/opt/newsroom/server/env/lib/python3.10/site-packages/newsroom/wire/search.py", line 349, in apply_request_filter
Dec  6 15:58:43 nh-cpcn-uat sh[1477]: 15:58:43 web.1         |     search.query["bool"]["must"].append({"range": {"versioncreated": date_range_query}})
Dec  6 15:58:43 nh-cpcn-uat sh[1477]: 15:58:43 web.1         | KeyError: 'must'

Purpose

Fixing error from uat logs.

What has changed

Steps to test

Checklist

  • This pull request is not adding new forms that use redux
  • This pull request is adding missing TypeScript types to modified code segments where it's easy to do so with confidence
  • This pull request is replacing lodash.get with optional chaining for modified code segments

Resolves: #[issue-number]

@petrjasek petrjasek added this to the v2.8.2 milestone Dec 10, 2024
@petrjasek petrjasek merged commit fbf46ea into superdesk:release/2.8 Dec 10, 2024
7 checks passed
@petrjasek petrjasek deleted the fix-errors branch December 10, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants