merge cp-lji branch to develop #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [SDAN-610] Photo coverage URL should not be generated on push but on get from the client (superdesk#896) * [SDAN-613] Corrected byline text and hyper-link for photo (superdesk#904) * [SDCP-114] - Consent checkbox for user sign up (superdesk#908)
* Missing french translations * Missing translations * More translations * Remove comma
* TBC Planning Items were shown in wrong order when Feature/Top story filter was ON (superdesk#1022) * [SDAN-668] (fix): Attribute error when accessing app.settings (superdesk#1026) * Allow date format override depending on language (superdesk#1033) * Allow date format override depending on language * Provide default value (for tests) * lint * Remove unused old variables Co-authored-by: vikas <nrvikas@gmail.com> Co-authored-by: MarkLark86 <mark.pittaway@gmail.com>
* Format dates with locale format * Convertion is not needed * lint * Fix tests
Co-authored-by: Tolga Akin <akint@aap.com.au>
|
@MarkLark86 I will go over it but if you could also scan it for any nonsense that would be great |
MarkLark86
reviewed
Dec 16, 2021
| * | ||
| * 'en' comes by default | ||
| */ | ||
| import 'moment/locale/fr-ca'; |
There was a problem hiding this comment.
This would need to be improved at some point, to use configured languages
MarkLark86
reviewed
Dec 16, 2021
newsroom/templates/download_item.txt
Outdated
| @@ -1,11 +1,7 @@ | |||
| {{ item.slugline }} | |||
| {{ item.headline }} | |||
| {{ item.source }} | |||
There was a problem hiding this comment.
This changes the default format of text downloads. Might need this modification in the customer's theme folder instead
|
@petrjasek I went over the changes. Not sure if I caught everything, but it mostly looked fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.