Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wire item tiles are not uniform in size for some searches #734

Merged
merged 4 commits into from
Jan 18, 2024

Conversation

dzonidoo
Copy link
Contributor

CPCN-401

Checklist

  • This pull request is not adding new forms that use redux
  • This pull request is adding missing TypeScript types to modified code segments where it's easy to do so with confidence
  • This pull request is replacing lodash.get with optional chaining for modified code segments

@dzonidoo dzonidoo requested a review from tomaskikutis January 16, 2024 13:08
@petrjasek petrjasek added this to the v2.7 milestone Jan 16, 2024
return (
<div key={i} className='d-flex gap-1 align-items-end'>
{children}
<span className='wire-articles__item__text--muted'>({numberOfNotRenderResults} more)</span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use gettext to translate word "more". Use parametrized string like "{{x}} more"

@dzonidoo dzonidoo merged commit 326cb7e into superdesk:develop Jan 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants