Fix topic being removed from folder on edit #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What was the cause of the issue? |
We were updating the topic regardless if one was created in the topic editor or not. |
assets/user-profile/actions.ts
Outdated
| @@ -258,20 +258,19 @@ export function saveFolder(folder: ITopicFolder, data: {name: string}, global?: | |||
| const state = getState(); | |||
| const url = getFoldersUrl(state.company, state.user?._id, global, folder._id); | |||
|
|
|||
| const returnFolder = (allFolders: IFoldersUnified, id: string) => | |||
There was a problem hiding this comment.
It's not a good practice to use the word return in the function name, because it causes confusion with the built-in return operator. Use get/find instead. I'd call it simply getFolder
tomaskikutis
approved these changes
Jan 28, 2024
petrjasek
pushed a commit
that referenced
this pull request
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CPCN-562
Checklist
lodash.getwith optional chaining for modified code segments