Implement the new navigation concept for Newshub #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrjasek
reviewed
Feb 28, 2024
assets/index.ts
Outdated
| const pinButton = document.getElementById('pin-btn'); | ||
|
|
||
| if (pinButton != null) { | ||
| pinButton.onclick = handleNavExpanded; |
There was a problem hiding this comment.
use pinButton.addEventListener it's a more idiomatic way to do this.
assets/index.ts
Outdated
| handleNavExpanded(); | ||
| } | ||
|
|
||
| function handleNavExpanded() { |
There was a problem hiding this comment.
Naming implies the function only runs on expansion, when in fact it also runs on collapsing. The name would be needed to be updated accordingly, but since that function is only used once - it doesn't make sesne to have it at all. Simply inline it in the event listener callback.
There was a problem hiding this comment.
but this function is not used only once...
There was a problem hiding this comment.
you're right - I missed the second usage. Then only improve the name.
assets/index.ts
Outdated
| } | ||
|
|
||
| function handleNavExpanded() { | ||
| if (element?.classList.contains('nav-block--pinned')) { |
There was a problem hiding this comment.
improve readability by returning early if element is null and doing the logic afterwards
tomaskikutis
approved these changes
Mar 15, 2024
petrjasek
approved these changes
Mar 15, 2024
petrjasek
pushed a commit
to petrjasek/newsroom-core
that referenced
this pull request
Aug 21, 2024
* add navigation * changes after review * fix lint * chages after review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NHUB-485
Checklist
lodash.getwith optional chaining for modified code segments