[SDAN-409] Fixing nested query for different filters. #662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akintolga
reviewed
Jan 10, 2019
| @@ -8,7 +8,7 @@ import AgendaCoverages from './AgendaCoverages'; | |||
|
|
|||
| export default function AgendaPreviewCoverages({item, currentCoverage, previousCoverage}) { | |||
| return ( | |||
| !isEmpty(currentCoverage) || !isEmpty(previousCoverage) && <Fragment> | |||
| <Fragment> | |||
There was a problem hiding this comment.
I previously added this check to prevent this error which was happenning locally: https://github.com/facebook/react/issues/12964
There was a problem hiding this comment.
I couldn't see any errors locally I have React 16.6. Error is fixed in 16.4.1. I will change the code to return null if current and previous coverages are empty.
mdhaman
force-pushed
the
fix-nested-query
branch
from
7c2b07a to
c3236e9
Compare
akintolga
approved these changes
Jan 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.