implement prompt #4698
Merged
implement prompt #4698
+92
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecalcc
approved these changes
Dec 11, 2024
scripts/core/prompt-modal.tsx
Outdated
Comment on lines
44
to
45
| this.props.onDone(this.state.value); | ||
| this.props.closeModal(); |
There was a problem hiding this comment.
Why don't you pass the state to closeModal and just have one function? So in the usage it would be:
closeModal={(value) => { ...processing closeModal(); <-- coming from showModal })
There was a problem hiding this comment.
Since both functions are not exposed to the options interface it makes sense to me
scripts/core/prompt-modal.tsx
Outdated
| position="top" | ||
| visible | ||
| onHide={this.props.closeModal} | ||
| headerTemplate="" |
There was a problem hiding this comment.
Is this necessary? From what I checked in UIF this is the interface for the prop headerTemplate?: JSX.Element | string;
There was a problem hiding this comment.
I meant to select only headerTemplate as the row to comment on, my bad
There was a problem hiding this comment.
that's how I understood it and only dropped headerTemplate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STT-63
A styled alternative to
window.prompt.