SDAAP-101: Fix issue with find pattern matching replace

[rbi-aap]

• Resolved problem where find pattern incorrectly matched the replace
• Improved regex handling to ensure correct replacements
• Added test cases to verify expected behavior

[rbi-aap]

Hi Andrew and Team, please review, thanks

[MarkLark86]

@tomaskikutis Could you please review this PR, and see if it is also needed in v2.8, 2.9 & develop branches please.
Cheers

[tomaskikutis]

@rbi-aap if the browser was freezing it was probably due to infinite loop. Why was it causing an infinite loop?

Is your code only handling the infinite loop issue? If not, what other issues is it handling?

I see after your changes, 2 different functions exist - one to replace at index and another to replace all. Could you stick to a single implementation in a similar fashion how it was previously? e.g. when multiple replacements were needed, the function doing a single replacement would be called multiple times.

[rbi-aap]

@tomaskikutis,
Thanks for the review. I refactored the replacement logic to improve stability, prevent unintended behavior, and ensure correct text updates. Unit tests were added to validate edge cases. Appreciate your time.

[tomaskikutis]

Could you answer to each of my 3 questions separatelly?

[rbi-aap]

@tomaskikutis ,Thanks for the review. The infinite loop was caused by unintended offset shifts leading to continuous execution and in turn, possible issues like callback hell, which have been fixed for stability. The update also prevents duplicate replacements and ensures correct text updates. The functions were split to avoid instability, as a single implementation didn’t handle multiple replacements reliably. thanks

[rbi-aap]

Hi Team, can you review more test case for QA with its function, thanks

[tomaskikutis]

Can you provide a sample input text, pattern and replacement text which was causing the infinite loop?

The update also prevents duplicate replacements and ensures correct text updates.

Can you specify samples where it was causing duplicate replacements or incorrect updates?

---

Please rework the tests so they are simpler

• limit sample text to a single line.
• Clean up test names so it is clear which use case is being tested. For example - this it not clear at all - "HIGHLIGHTS_FIND_REPLACE_SINGLE_AND_REPLACE_ALL"

---

Replace all $ with $AUD ,but no change with $AUD - this one is asserting incorrect behavior. It should replace $AUD too with the pattern that you specified.

'I have $100 in my wallet. The total cost is $50, but sometimes it is $AUD60'.replace(/\$/g, '$AUD')
// > 'I have $AUD100 in my wallet. The total cost is $AUD50, but sometimes it is $AUDAUD60'

[rbi-aap]

Hi @tomaskikutis,

Thanks for your review!

• Infinite loop sample: "$100" with pattern "$" and replacement "$AUD" looped endlessly.
• Update resolves duplicates and ensures correct replacements.
• Fixed duplicate sample: "$AUD60" no longer becomes "$AUDAUD60" with "$" → "$AUD".
• Tests are simpler, using AAA pattern—see new commit.
• Sample text now single-line, e.g., "Total: $100, cost: $50".
• Test names improved, e.g., "CombinedReplacementScenarios".
• Added QA test for edge cases.

Really appreciate your support!

[tomaskikutis]

I've looked into the issue and indeed there is a bug with an infinite loop. The cause was that the function was performing replacement on text that was already replaced.

For example if text was air and we wanted to replace "air" with "airplane", it would do it correctly the first iteration, but then would search for "air" in "airplane" and would replace to "airplaneplane", then to "airplaneplaneplane" - and would never stop.

I've fixed the infinite loop in #4758 by adjusting code so it does not attempt to replace what was already replaced once.

Besides that - I don't see any other issues.

Your comment about duplicates is describing correct behavior. I've added a test that given text "dev dev dev" and trying to replace "dev" with "developers" it should output "developers developers developers". It's not a bug - that's how "replace all" is supposed to work.

Regarding currency conversion where you want to change "$" to "$AUD" - but keep existing mentions of "$AUD" intact - that can't be done with "find and replace" feature without regex support. I don't suggest to expose regex support directly to end-users either - that'd be an overkill for superdesk users.

The best solution I think would be to have pre-made custom replacement strategies. It could either be integrated into "find and replace" widget or you could use macros. There is one already for USD to CAD conversion.