fix(sentry): Replace raven with sentry-sdk (#2770)

* fix(sentry): Replace raven with sentry-sdk

* ignore sentry-sdk type missing imports

content_api/app/__init__.py

@@ -29,7 +29,6 @@
 from superdesk.factory.elastic_apm import setup_apm
 from superdesk.validator import SuperdeskValidator
 from superdesk.factory.app import SuperdeskEve, set_error_handlers, get_media_storage_class
-from superdesk.factory.sentry import SuperdeskSentry
 
 
 def get_app(config=None):
@@ -82,8 +81,6 @@ def get_app(config=None):
         except AttributeError:
             pass
 
-    app.sentry = SuperdeskSentry(app)
-
     return app
 
 

prod_api/app/__init__.py

@@ -26,7 +26,6 @@
 from superdesk.factory.elastic_apm import setup_apm
 from superdesk.validator import SuperdeskValidator
 from superdesk.factory.app import SuperdeskEve, set_error_handlers, get_media_storage_class
-from superdesk.factory.sentry import SuperdeskSentry
 
 from prod_api.auth import JWTAuth
 
@@ -90,8 +89,6 @@ def get_app(config=None):
         else:
             init_app(app)
 
-    app.sentry = SuperdeskSentry(app)
-
     return app
 
 

setup.cfg

@@ -153,7 +153,7 @@ ignore_missing_imports = True
 [mypy-draftjs_exporter.*]
 ignore_missing_imports = True
 
-[mypy-raven.*]
+[mypy-sentry_sdk.*]
 ignore_missing_imports = True
 
 [mypy-kombu.*]

setup.py

@@ -31,7 +31,7 @@
     "ldap3>=2.2.4,<2.10",
     "pytz>=2021.3",
     "tzlocal>=5.2",
-    "raven[flask]>=5.10,<7.0",
+    "sentry-sdk[quart]>=1.5.7,<2.0",
     "requests>=2.7.0,<3.0",
     "boto3>=1.26,<2.0",
     "websockets>=12.0,<13.2",

superdesk/factory/app.py

@@ -19,6 +19,9 @@
 import superdesk
 import logging
 
+import sentry_sdk
+from sentry_sdk.integrations.asyncio import AsyncioIntegration
+from sentry_sdk.integrations.quart import QuartIntegration
 from flask_mail import Mail
 from eve.auth import TokenAuth
 from eve.io.mongo.mongo import _create_index as create_index
@@ -42,7 +45,6 @@
 from superdesk.celery_app import init_celery
 from superdesk.datalayer import SuperdeskDataLayer  # noqa
 from superdesk.errors import SuperdeskError, SuperdeskApiError, DocumentError
-from superdesk.factory.sentry import SuperdeskSentry
 from superdesk.logging import configure_logging
 from superdesk.storage import ProxyMediaStorage
 from superdesk.validator import SuperdeskValidator
@@ -225,8 +227,8 @@ def __init__(self, **kwargs):
         self._endpoint_groups = []
         self._endpoint_lookup = {}
         super().__init__(**kwargs)
+        self.setup_sentry()
         self.async_app = SuperdeskAsyncApp(self)
-
         self.teardown_request(self._after_each_request)
 
     def __getattr__(self, name):
@@ -399,6 +401,19 @@ def get_current_request(self, req=None) -> HttpFlaskRequest | None:
             new_request.user = self.async_app.auth.get_current_user(new_request)
         return new_request
 
+    def setup_sentry(self):
+        if not self.config.get("SENTRY_DSN"):
+            return
+
+        # Given how quart_flask_patch patches things, it makes Sentry SDK to think that flask is installed
+        # mistakenly enabling FlaskIntegration, which breaks QuartIntegration, and preventing sentry from working properly.
+        # https://github.com/pgjones/quart-flask-patch/blob/0.3.0/src/quart_flask_patch/_patch.py#L110
+        # This prevents flask integration from being enabled at all until we're can use a newer version of sentry-sdk where
+        # specific integrations can be disabled https://github.com/getsentry/sentry-python/releases/tag/2.11.0
+        sentry_sdk.integrations._processed_integrations.add("flask")
+
+        sentry_sdk.init(dsn=self.config["SENTRY_DSN"], integrations=[QuartIntegration(), AsyncioIntegration()])
+
 
 def get_media_storage_class(app_config: Dict[str, Any], use_provider_config: bool = True) -> Type[MediaStorage]:
     if use_provider_config and app_config.get("MEDIA_STORAGE_PROVIDER"):
@@ -471,7 +486,6 @@ def get_app(config=None, media_storage=None, config_object=None, init_elastic=No
 
     app.jinja_loader = custom_loader
     app.mail = Mail(app)
-    app.sentry = SuperdeskSentry(app)
     cache_backend.init_app(app)
     setup_apm(app)