-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDCP-408] [Server] Scheduled exports of event and planning filters #1513
Conversation
I wonder if we could reuse some parts of report scheduling from core where we use |
This might be a good improvement down the line. I had a quick look at superdesk-core, there are multiple areas that use scheduling from So it might be better to merge all 5 scheduling systems into a single system as an improvement later. I also didn't like the idea of storing the schedule in a very specific format, i.e. using cron format. I believe we should not tie down our DB schema to a particular implementation, instead we can create a converter from our DB schema to the usage (in this case cron). I could change this code to have this converter and use croniter instead. |
yep doing some refactoring in core first would make sense
I would always prefer some kind of standard format to our custom, that's like reinventing the wheel, but there might be more descriptive format than cron for sure |
Makes sense. Would you mind if I merge this one, and we can discuss later the specifics of a more generalised solution that will work everywhere? |
you can go ahead and merge |
No description provided.