Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDCP-408] [Server] Scheduled exports of event and planning filters #1513

Merged
merged 11 commits into from
Jan 19, 2021

Conversation

MarkLark86
Copy link
Collaborator

No description provided.

@MarkLark86 MarkLark86 added this to the 2.1 milestone Jan 12, 2021
@petrjasek
Copy link
Member

petrjasek commented Jan 15, 2021

I wonder if we could reuse some parts of report scheduling from core where we use
https://pypi.org/project/croniter/ , but not sure if the requirements are the same

@MarkLark86
Copy link
Collaborator Author

MarkLark86 commented Jan 18, 2021

I wonder if we could reuse some parts of report scheduling from core where we use
https://pypi.org/project/croniter/ , but not sure if the requirements are the same

This might be a good improvement down the line. I had a quick look at superdesk-core, there are multiple areas that use scheduling from croniter and each have their own functions that do similar things (working out next schedule date etc). We also have scheduling in Analytics (which uses the same logic I've implemented here).

So it might be better to merge all 5 scheduling systems into a single system as an improvement later.

I also didn't like the idea of storing the schedule in a very specific format, i.e. using cron format. I believe we should not tie down our DB schema to a particular implementation, instead we can create a converter from our DB schema to the usage (in this case cron). I could change this code to have this converter and use croniter instead.

@petrjasek
Copy link
Member

yep doing some refactoring in core first would make sense

I also didn't like the idea of storing the schedule in a very specific format, i.e. using cron format. I believe we should not tie ? down our DB schema to a particular implementation, instead we can create a converter from our DB schema to the usage (in this case cron). I could change this code to have this converter and use croniter instead.

I would always prefer some kind of standard format to our custom, that's like reinventing the wheel, but there might be more descriptive format than cron for sure

@MarkLark86
Copy link
Collaborator Author

Makes sense. Would you mind if I merge this one, and we can discuss later the specifics of a more generalised solution that will work everywhere?

@petrjasek
Copy link
Member

you can go ahead and merge

@MarkLark86 MarkLark86 merged commit 4f91f1f into superdesk:develop Jan 19, 2021
@MarkLark86 MarkLark86 added the merged Merged into release branch label Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged Merged into release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants