Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDNTB-673] Support filtering/sorting by created/updated #1555

Merged
merged 25 commits into from
Mar 9, 2021
Merged

[SDNTB-673] Support filtering/sorting by created/updated #1555

merged 25 commits into from
Mar 9, 2021

Conversation

MarkLark86
Copy link
Collaborator

No description provided.

@MarkLark86 MarkLark86 added this to the 2.3 milestone Mar 1, 2021
@MarkLark86 MarkLark86 marked this pull request as draft March 1, 2021 09:22
@MarkLark86 MarkLark86 marked this pull request as ready for review March 4, 2021 07:01
@MarkLark86 MarkLark86 requested review from GyanP and petrjasek March 4, 2021 07:01
@petrjasek
Copy link
Member

not sure why we should use _created and _updated rather than firstcreated and versioncreated fields, any reason for that?

@MarkLark86
Copy link
Collaborator Author

not sure why we should use _created and _updated rather than firstcreated and versioncreated fields, any reason for that?

I'm not sure why we have 4 fields for the same thing. So I chose _created and _updated. Is there any difference between these fields?

@petrjasek
Copy link
Member

that _created and _updated is automatically set by eve, while the others are handled manually. so we can ingest those and use them in the output without being changed

MarkLark86 added a commit to MarkLark86/superdesk-planning that referenced this pull request Mar 5, 2021
@MarkLark86
[SDESK-5827] fix: Search panel params not persisting
68fcf5a 
This has been backported from superdesk#1555
@MarkLark86 MarkLark86 mentioned this pull request Mar 5, 2021
Merged
MarkLark86 added a commit that referenced this pull request Mar 5, 2021
@MarkLark86
[SDESK-5827] fix: Search panel params not persisting (#1558)
f594489 
* [SDESK-5827] fix: Search panel params not persisting
This has been backported from #1555

* Change e2e cores to master branch
@MarkLark86 MarkLark86 merged commit 6fb5bb7 into superdesk:develop Mar 9, 2021
@MarkLark86 MarkLark86 added the merged Merged into release branch label Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrjasek petrjasek petrjasek approved these changes

@GyanP GyanP Awaiting requested review from GyanP

Assignees
No one assigned
Labels
merged Merged into release branch
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkLark86 @petrjasek