[SDCP-529] Fix various UI translations #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MarkLark86
commented
May 5, 2021
MarkLark86
commented
- Patch strings in constant files after superdeskApi has initialised
- update planning.pot
Patch strings in constant files after superdeskApi has initialised
petrjasek
reviewed
May 5, 2021
petrjasek
approved these changes
May 5, 2021
There was a problem hiding this comment.
I'm not sure about that approach with assigning the translated labels later, imo it's a bit error prone as you can use the labels before those are translated. we can give it a try, maybe we can set some placeholder there rather then the actual string so it would be obvious if it's not used correctly
| msgstr "" | ||
|
|
||
| #: client/components/ConfirmationModal.tsx:108 | ||
| msgid "Are you sure ?" |
|
These labels are used in React components, which are rendered by an AngularJS controller. So here we can guarantee they will be set for UI purposes. I agree, it's not a good solution. Tomas has ideas we can discuss, maybe for 2.4? |
|
sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.