Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDCP-528] fix: Select dropdowns failed to re-render on language change #1582

Merged
merged 1 commit into from
May 24, 2021
Merged

[SDCP-528] fix: Select dropdowns failed to re-render on language change #1582

merged 1 commit into from
May 24, 2021

Conversation

MarkLark86
Copy link
Collaborator

Replaces usage of getDerivedStateFromProps with lodash.memoize in the newer Select component

@MarkLark86 MarkLark86 added this to the 2.3 milestone May 21, 2021
@MarkLark86 MarkLark86 requested review from a team and GyanP and removed request for a team May 21, 2021 06:28
@MarkLark86 MarkLark86 merged commit 2ade0bf into superdesk:develop May 24, 2021
@MarkLark86 MarkLark86 added the merged Merged into release branch label Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GyanP GyanP GyanP approved these changes

@petrjasek petrjasek petrjasek approved these changes

Assignees
No one assigned
Labels
merged Merged into release branch
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MarkLark86 @petrjasek @GyanP