Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix onclusive api offset param handling #1713

Merged
merged 2 commits into from
Aug 31, 2022
Merged

fix onclusive api offset param handling #1713

merged 2 commits into from
Aug 31, 2022

Conversation

petrjasek
Copy link
Member

  • it wasn't really used because of missing = in the url
  • it started with 100 so missed first 100 events always

@petrjasek
fix onclusive api offset handling
c1c6cf4 
there was `=` missing in the url, but refactored it to be less error
prone
@petrjasek
fix the initial offset when using onclusive api
a22275d 
- so it's not skipping first 100 items
@petrjasek petrjasek added this to the 2.6 milestone Aug 30, 2022
@petrjasek petrjasek merged commit e37c559 into superdesk:develop Aug 31, 2022
@petrjasek petrjasek deleted the fix-onclusive-api-offset branch August 31, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkLark86 MarkLark86 MarkLark86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6
Development

Successfully merging this pull request may close these issues.
2 participants
@petrjasek @MarkLark86