Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement the behavior to remove the date label and day browser on small screens [SDESK-6930] #1806

Merged
merged 8 commits into from
May 19, 2023

Conversation

devketanpro
Copy link
Member

No description provided.

@devketanpro devketanpro added this to the 2.7 milestone May 17, 2023
client/apps/Planning/PlanningListSubNav.tsx Outdated Show resolved Hide resolved
client/apps/style.scss Outdated Show resolved Hide resolved
client/apps/style.scss Outdated Show resolved Hide resolved
@devketanpro devketanpro requested a review from fritzSF May 17, 2023 13:16
Copy link
Contributor

@fritzSF fritzSF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The behaviour is still not OK. There are four different layout scenarios to consider here:

  • Just the list view open
  • List view + preview open
  • List view + editor open
  • List view + preview + editor open

I suggest using a container query here instead of a media query. This would be much simpler, having all these options in mind.

A few other things:
There is no space in front of the "Assigned to:" label.
Image 2023-05-17 at 8 08 12 PM
Was it a request that the "Day, Week, Month" dropdown remains instead of the calendar dropdown like it was before?
Image 2023-05-17 at 8 28 32 PM

"Assigned to:" should have a span with a class around it. Like this:
<span class="sd-margin-l--1 sd-opacity--75 ">Assigned to:</span>

client/apps/Planning/PlanningListSubNav.tsx Outdated Show resolved Hide resolved
@devketanpro devketanpro requested a review from fritzSF May 18, 2023 11:55
Copy link
Contributor

@fritzSF fritzSF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not good.
.sd-page-content--slide-in--open is not contained in the subnav, so the query can't work.

Try this instead:
@container subnav (max-width: 800px) { .hideOnMobile { .icn-btn, .btn, .subnav-calendar { display: none; } } }

Please test before pushing the changes.

@devketanpro devketanpro removed the request for review from petrjasek May 19, 2023 13:49
@devketanpro devketanpro merged commit bc24ffb into superdesk:develop May 19, 2023
@devketanpro devketanpro deleted the SDESK-6930 branch November 22, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants