-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement the behavior to remove the date label and day browser on small screens [SDESK-6930] #1806
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The behaviour is still not OK. There are four different layout scenarios to consider here:
- Just the list view open
- List view + preview open
- List view + editor open
- List view + preview + editor open
I suggest using a container query here instead of a media query. This would be much simpler, having all these options in mind.
A few other things:
There is no space in front of the "Assigned to:" label.
Was it a request that the "Day, Week, Month" dropdown remains instead of the calendar dropdown like it was before?
"Assigned to:" should have a span with a class around it. Like this:
<span class="sd-margin-l--1 sd-opacity--75 ">Assigned to:</span>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not good.
.sd-page-content--slide-in--open
is not contained in the subnav, so the query can't work.
Try this instead:
@container subnav (max-width: 800px) { .hideOnMobile { .icn-btn, .btn, .subnav-calendar { display: none; } } }
Please test before pushing the changes.
No description provided.