[SDBELGA-778] fix: Show recurring Planning update method on Ignore|Cancel|Save modal #1930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncel|Save modal Also improve look and feel when rendering Event & Planning metadata in the modal
tomaskikutis
approved these changes
Mar 14, 2024
| EVENTS.UPDATE_METHODS[0].value; | ||
| eventUpdates.update_method = eventUpdates.update_method == null ? | ||
| EVENTS.UPDATE_METHODS[0].value : | ||
| eventUpdates.update_method?.value ?? eventUpdates.update_method; |
There was a problem hiding this comment.
According to defined type for update_method - it's a union of strings. It'd be best to either update the type or remove the logic where .value is accessed.
There was a problem hiding this comment.
@tomaskikutis These are the ulgy parts of the code that I was talking about in last night's Scrum. Some of the ItemActionModals provide the enableSaveInModal and update_method differently. IMO we can leave as is for now, as long as it works, until we refactor the modals in Planning
| modalProps: IModalProps; | ||
| enableSaveInModal(): void; | ||
| resolve(item?: IEventItem): void; | ||
| enableSaveInModal?(): void; |
There was a problem hiding this comment.
Since this function is taken as prop and then unconditionally executed on componentDidMount - why not simply execute it in a parent component instead of passing a prop here?
MarkLark86
added a commit
that referenced
this pull request
Jun 19, 2024
* [SDBELGA-778] fix: Show recurring Planning update method on Ignore|Cancel|Save modal (#1930) * [SDBELGA-778] fix: Show recurring Planning update method on Ignore|Cancel|Save modal Also improve look and feel when rendering Event & Planning metadata in the modal * fix(ci): Use superdesk/release/2.7 branch for test instance * fix extension build error * add new should_udpate func [SDCP-742] (#1963) * add new should_udpate func [SDCP-742] * update params * refactore logic * Onclusive parse new key for event status mapping [SDCP-749] (#1970) * Onclusive parse new key for event status mapping [SDCP-749] * address comment * Fix content profile closing after canceling a groups' creation (#1964) * implement onclusive reingesting (#1971) SDCP-751 * drop angular-history (#1933) * drop angular-history * fix test build * sync redux versions with client core * update package-lock * update events during ingest if name/subject changes SDCP-751 * allow removing contact email/phone via update (#1979) SDCP-762 * set expiry when parsing onclusive events (#1995) * set expiry when parsing onclusive events CPCN-825 * fix mypy * bump version * update ui framework version (#1997) * fix ci * Set version to 2.8.0-dev --------- Co-authored-by: MarkLark86 <mark.pittaway@gmail.com> Co-authored-by: Ketan <73937490+devketanpro@users.noreply.github.com> Co-authored-by: Konstantin Markov <maga.ot.oz@protonmail.com>
MarkLark86
added a commit
that referenced
this pull request
Jun 19, 2024
… schema (#1996) * Bump coverage from 7.5.1 to 7.5.3 (#1994) Bumps [coverage](https://github.com/nedbat/coveragepy) from 7.5.1 to 7.5.3. - [Release notes](https://github.com/nedbat/coveragepy/releases) - [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst) - [Commits](nedbat/coveragepy@7.5.1...7.5.3) --- updated-dependencies: - dependency-name: coverage dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update interfaces * Update redux reducers * Update redux selectors * Update redux actions * Update websocket notification handling * Update internal PlanningAPI * Update UI components * Update utils * Update package-lock.json * fix unit test * Add comment to IPlanningRelatedEventLinkType interface, update variable name * merging `release/2.7` to develop (#1998) * [SDBELGA-778] fix: Show recurring Planning update method on Ignore|Cancel|Save modal (#1930) * [SDBELGA-778] fix: Show recurring Planning update method on Ignore|Cancel|Save modal Also improve look and feel when rendering Event & Planning metadata in the modal * fix(ci): Use superdesk/release/2.7 branch for test instance * fix extension build error * add new should_udpate func [SDCP-742] (#1963) * add new should_udpate func [SDCP-742] * update params * refactore logic * Onclusive parse new key for event status mapping [SDCP-749] (#1970) * Onclusive parse new key for event status mapping [SDCP-749] * address comment * Fix content profile closing after canceling a groups' creation (#1964) * implement onclusive reingesting (#1971) SDCP-751 * drop angular-history (#1933) * drop angular-history * fix test build * sync redux versions with client core * update package-lock * update events during ingest if name/subject changes SDCP-751 * allow removing contact email/phone via update (#1979) SDCP-762 * set expiry when parsing onclusive events (#1995) * set expiry when parsing onclusive events CPCN-825 * fix mypy * bump version * update ui framework version (#1997) * fix ci * Set version to 2.8.0-dev --------- Co-authored-by: MarkLark86 <mark.pittaway@gmail.com> Co-authored-by: Ketan <73937490+devketanpro@users.noreply.github.com> Co-authored-by: Konstantin Markov <maga.ot.oz@protonmail.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Petr Jašek <jasekpetr@gmail.com> Co-authored-by: Ketan <73937490+devketanpro@users.noreply.github.com> Co-authored-by: Konstantin Markov <maga.ot.oz@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also improve look and feel when rendering Event & Planning metadata in the modal