Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix suggestions #2001

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Fix suggestions #2001

merged 3 commits into from
Jun 19, 2024

Conversation

thecalcc
Copy link
Contributor

SDBELGA-815
Lowercase search query match has been adjusted, and also if the input text matches a suggestion (case sensitive), that suggestion disappears and only other ones that don't match the input do appear

Screen.Recording.2024-06-19.at.13.22.08.mov

@tomaskikutis
Copy link
Member

Could you update the ticket so the issue is clearly defined? I think it's more correct to always show all matching results, irrespective of case. So if you type Test but Test and test should appear. I don't think any well configured data source should have items that are same, except capitalization.

@thecalcc thecalcc merged commit c8d71f1 into superdesk:develop Jun 19, 2024
12 checks passed
@petrjasek petrjasek added this to the 2.8 milestone Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants