Respect date filter in event list for multi day events #2007
Conversation
| groups={groups} | ||
| groups={groups.filter((group) => { | ||
| const groupDateToMoment = moment(group.date); | ||
| const dateFilter = currentSearch.advancedSearch?.dates?.start; |
There was a problem hiding this comment.
does this view only get rendered in search?
There was a problem hiding this comment.
Gets rendered in Combined, Planning only and Event only views
There was a problem hiding this comment.
Only in search mode? You're filtering out items that don't have some search filters. What if user isn't in search mode?
There was a problem hiding this comment.
If user isn't in search mode the filter would be pointless. Good point, I'll add a check beforehand so we don't iterate needlessly, we can pass the items right away
There was a problem hiding this comment.
Needless iteration aside, wouldn't there have been a bug in previous code ^ where if you are not in search mode, there would be no groups visible? Since if dateFilter is null you were returning false from the filter function?
There was a problem hiding this comment.
Nope, date filter has a default of today, so in theory, it's never null
There was a problem hiding this comment.
I see. Still, no filter should mean no filtering should be happening. Which means all items should be returned. Even if all existing code paths return the same result before/after, your latest approach is still better.
There's a good rule of least surprise that I haven't had a chance to mention to you yet that applies here.
|
@tomaskikutis added a comment & pushed changes |
SDESK-7310