Planning: Adjust and improve the visual indication of the workflow status of Coverages #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
client/utils/planning.ts
Outdated
| return 'var(--sd-colour-success)'; | ||
| } else if (isCoverageDraft(coverage) || get(coverage, 'workflow_status') === COVERAGES.WORKFLOW_STATE.ACTIVE) { | ||
| return 'var(--sd-colour-highlight)'; | ||
| function getCoverageIconColor(item: IPlanningCoverageItem, field = 'state'): string { |
There was a problem hiding this comment.
Do not add field parameter if it's not used. It makes it appear as multiple options are available and in the end it makes it harder to understand all possible usages.
client/utils/planning.ts
Outdated
| return 'var(--sd-colour-state--completed)'; | ||
| } | ||
|
|
||
| if (item.assigned_to.user === null || item.assigned_to.desk === null) { |
There was a problem hiding this comment.
Avoid using negatives in naming and flow. For example, it wouldn't be a good name const notUnassigned= true because it is difficult to understand. In a similar manner, your if condition is whether "unassigned" label should be applied. Instead use the condition to determine if assigned should be applied and use "else" for unassigned.
tomaskikutis
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDESK-7311